Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoBitLocker resource does not encrypt volumes with drive letter assigned #10

Closed
MartinVokurek opened this issue May 23, 2018 · 1 comment
Labels
enhancement The issue is an enhancement request.

Comments

@MartinVokurek
Copy link
Contributor

Function GetAutoBitLockerStatus in MSFT_xBLAutoBitlocker.psm1 uses $allBlvs = Get-BitLockerVolume | where {$_.VolumeType -eq "Data"} at line 365 to get list of Data volumes and
Get-Volume -Path $blv.MountPoint to filter Fixed vs Removable at line 381. This works fine for volumes without drive letter assigned (mountpoint returned by Get-BitlockerVolume is \\?\Volume{<guid>}\

But for volumes with drive letter assigned, Get-Volume -Path does not work. In that case, it is necessary to use Get-Volume -DriveLetter instead.

MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 23, 2018
AutoBitLocker should handle volumes with drive letter assigned now
@johlju
Copy link
Member

johlju commented May 24, 2018

Labeling this as an enhancement and help wanted so anyone in the community can run with it.

Maybe we can use Split-Path to determine which named parameter to use?

PS > Split-Path -Path '\\?\Volume{<guid>}\' -IsAbsolute
False
PS > Split-Path -Path 'E:\' -IsAbsolute
True

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels May 24, 2018
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 24, 2018
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 28, 2018
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 28, 2018
AutoBitLocker should handle volumes with drive letter assigned now
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 28, 2018
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 31, 2018
AutoBitLocker should handle volumes with drive letter assigned now
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 31, 2018
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue May 31, 2018
AutoBitLocker should handle volumes with drive letter assigned now
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue Jun 4, 2018
Fix for issue dsccommunity#11
Readme updates
MartinVokurek pushed a commit to MartinVokurek/xBitlocker that referenced this issue Jun 4, 2018
@johlju johlju closed this as completed in #17 Jun 5, 2018
johlju pushed a commit that referenced this issue Jun 5, 2018
- Fixed issue which caused xBLAutoBitlocker to incorrectly detect Fixed vs Removable volumes (issue #11).
- Fixed issue which made xBLAutoBitlocker unable to encrypt volumes with drive letters assigned (issue #10).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

No branches or pull requests

2 participants