xWebsite Inconsistent Logic in xWebsite #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
from
e2e8428 to
91c5357
Compare
|
These test failures don't look like they are related to the changes made in the PR. |
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
8 times, most recently
from
db7e107 to
d9ed771
Compare
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
from
d9ed771 to
59e8dcc
Compare
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
4 times, most recently
from
8c35ce7 to
b8255da
Compare
|
Waiting on #568 |
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
2 times, most recently
from
0cf416c to
bd4dab4
Compare
|
Turned out this was also waiting on #565. |
The Test-TargetResource function in the xWebSite resource used inconsistent logic in the way that it would test a property for compliance and then report non-compliance. Some tests would use the `$PSBoundParameters` variable to check for parameters to be tested, others would use `[String]::isNullOrEmpty()` Some tests would set the `$inDesiredState` variable, write a verbose message and move on, and others would write the verbose message and use the `return` keyward to immediately exit the function and stop testing additional properties. The desired style should use `$PSBoundParameters` and the `$inDesiredState` variable consistently, so that all properties are tested for troubleshooting purposes, and to promote conciseness and reasability Resolves dsccommunity#221
RandomNoun7
force-pushed
the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
from
bd4dab4 to
e7da5b9
Compare
|
Ok, that had a transient failure, but this is fully rebased and tests passing. Ready to go. |
regedit32
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
RandomNoun7
deleted the
ghissues/221-inconsistent-logic-xwebsite-test-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The Test-TargetResource function in the xWebSite resource used
inconsistent logic in the way that it would test a property for
compliance and then report non-compliance.
Some tests would use the
$PSBoundParametersvariable to check forparameters to be tested, others would use
[String]::isNullOrEmpty()Some tests would set the
$inDesiredStatevariable, write a verbosemessage and move on, and others would write the verbose message and
use the
returnkeyward to immediately exit the function and stoptesting additional properties.
The desired style should use
$PSBoundParametersand the$inDesiredStatevariable consistently, so that all properties aretested for troubleshooting purposes, and to promote conciseness and
reasability
This Pull Request (PR) fixes the following issues
Resolves #221
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
and comment-based help.
This change is