Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xWebAdministration: New folder structure for examples #500

Merged
merged 2 commits into from
Oct 1, 2019
Merged

xWebAdministration: New folder structure for examples #500

merged 2 commits into from
Oct 1, 2019

Conversation

tomlarse
Copy link
Contributor

@tomlarse tomlarse commented Oct 1, 2019 •
edited
Loading

Pull Request (PR) description

Directory structure as described in #483. This should probably be merged before work on #484, #485, #486, #487 and #491 is done.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Oct 1, 2019 •
edited
Loading

Codecov Report

Merging #500 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #500   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          17       17           
  Lines        2661     2661           
=======================================
  Hits         2432     2432           
  Misses        229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41f18a...8ca3aa5. Read the comment docs.

johlju
johlju requested changes Oct 1, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 25 of 25 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tomlarse)

a discussion (no related file):
Just a tiny comment. Could you please update the change log with an entry explaining this change?

@johlju johlju mentioned this pull request Oct 1, 2019
Merged
9 tasks
@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 1, 2019
@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

yeah, sorry. I missed that :) Is that okay, or should the description be different?

johlju
johlju approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :) It looks good to me

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. labels Oct 1, 2019
johlju
johlju approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju changed the title EXAMPLES: changes described in #483 xWebAdministration: new folder structure for examples Oct 1, 2019
@johlju johlju changed the title xWebAdministration: new folder structure for examples xWebAdministration: New folder structure for examples Oct 1, 2019
@johlju johlju merged commit e0907fe into dsccommunity:dev Oct 1, 2019
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Oct 1, 2019
@tomlarse tomlarse deleted the iss483 branch October 1, 2019 19:35
@johlju
Copy link
Member

johlju commented Oct 1, 2019

@tomlarse Thank you for this! 😄

@tomlarse
Copy link
Contributor Author

tomlarse commented Oct 1, 2019

Glad to be of any help 😁

gstorme pushed a commit to gstorme/xWebAdministration that referenced this pull request Feb 14, 2020
@tomlarse
xWebAdministration: New folder structure for examples (dsccommunity#500)
618a110 
- Changes to Examples
  - Created new folder structure for examples so that examples will be
  placed in `/Examples/Resources/$resourceName` (issue dsccommunity#483).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju johlju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xWebAdministration: Examples should be in individual resource folders
3 participants
@tomlarse @codecov-io @johlju