Feature: #241 Anonymous authentication

[cezarypiatek]

Pull Request (PR) description

This is an attempt of implementing the ability to configure credentials for anonymous authentication.
I added AnonymousCredentials parameter for xWebsite module. I've started adding UT but I've got stuck with this weird error related to CIM objects. Can anybody review my current changes and help me with this issue? Error message that I get from UT:

    [-] Error occurred in Context block 335ms
      ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
      Parameter name: className
" to type "Microsoft.Management.Infrastructure.CimInstance". Error: "Specified argument was out of the range of valid values.
      Parameter name: className"
" to type "Microsoft.Management.Infrastructure.CimInstance". Error: "Specified argument was out of the range of valid values.
      Parameter name: className"
" to type "Microsoft.Management.Infrastructure.CimInstance". Error: "Specified argument was out of the range of valid values.als'. Cannot convert value "MSFT_xWebAnonymousAuthenticationCredentials
      Parameter name: className"
      at <ScriptBlock>, C:\Repositories\current\xWebAdministration\Tests\Unit\MSFT_xWebsite.Tests.ps1: line 557
      at DescribeImpl, C:\Program Files\WindowsPowerShell\Modules\Pester\4.3.1\Functions\Describe.ps1: line 161

This Pull Request (PR) fixes the following issues #241

• Fixes Add Support for Editing Anonymous Authentication Credentials #241:

Task list

• Added an entry under the Unreleased section of the change log in the README.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[msftclas]

All CLA requirements met.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[johlju]

@cezarypiatek Is the errors you getting unrelated to the changes in this PR? Could you please rebase against the dev branch. That will kick off the tests agai, and if the errors you are seeing is unrelated to the changes, maybe they pass this time.
It is also possible to kick off the tests again by closing and then directly reopening the same PR.

[cezarypiatek]

@johlju these errors are certainly related to my changes. I asked for help in #241 but nobody respond so far. There is something wrong with CIM object and I can't cope with this by myself. I need a help.

[johlju]

I understand. Always happy to help, but I been overwhelmed at work last quarter, and guess @regedit32 also have been busy. Sorry it took so long for someone to look at this and help you.

I had a quick look at this and debugged it in VS Code. I saw a back tick that was placed wrong.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @cezarypiatek)

a discussion (no related file):
Could you please rebase against branch dev using git rebase (not by using git pull or git merge, to keep the commit history). If you don't know how to rebase your local dev and working branch, please look at how to Resolve merge conflicts.
Let me know if you need any assistance.

---

---

Tests/Unit/MSFT_xWebsite.Tests.ps1, line 560 at r1 (raw file):

-AnonymousCredentials  $MockAnonymousCredentials`

The back tick should be one space apart. This is what is giving the issue in the tests.
Also, there is an extra space between the parameter name and the variable name.

Should be: -AnonymousCredentials $MockAnonymousCredentials `

[codecov-io]

Codecov Report

Merging #408 into dev will decrease coverage by 0.26%.
The diff coverage is 73.91%.

@@            Coverage Diff            @@
##              dev    #408      +/-   ##
=========================================
- Coverage   90.77%   90.5%   -0.27%     
=========================================
  Files          17      17              
  Lines        2438    2434       -4     
=========================================
- Hits         2213    2203      -10     
- Misses        225     231       +6

Impacted Files	Coverage Δ
DSCResources/MSFT_xWebsite/MSFT_xWebsite.psm1	96.07% <73.91%> (-1.05%)	⬇️
...SCResources/MSFT_xIisLogging/MSFT_xIisLogging.psm1	97.58% <0%> (-0.17%)	⬇️
DSCResources/Helper.psm1	90% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e1778f...e665489. Read the comment docs.

[cezarypiatek]

@johlju thanks for help, now I can continue my work with this feature.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[johlju]

@cezarypiatek Please see comments in the issue #241. Tag me here if that was not the cause of the problem and I can dig in further.
You can also debug the build worker by connecting to it by RDP if it helps. You could re-run the integration tests manually and test the code.