-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xWebAdministration: Move example from README.md to examples folder #485
Comments
I think I'd like to take a crack at this. Is this literally just taking the example and putting it in it's own ps1 file in the examples folder? I'm assuming that you'd still want the PHP instructions on the page, with a link to the example. |
@Tuxhedoh Yeah, just put in the root of the Examples folder. Make sure the name says something with end-to-end so we can differentiate it from the individual resource examples (that should go in separate folders mentioned in another issue). For the text, please add a comment-based help block as seen here. |
All text goes in the comment-based help block, and remove it from the README.md entirely. |
What's the proper etiquette when it comes to handling multiple issues in one repo? Make one PR and resolve them all? There seems to be quite a bit of low hanging fruit in this project. I recognize with Hacktoberfest there will probably be quite a few people clamoring for the issues to get their 4 pr's. |
Just mention in an issue that your are working on it, then you may send in one PR that resolves them all or several PR's that solves one each. Normally I personally send in a PR fixing a bunch of PR's. I expect during October to get small PR's resolving one issue. That was my meaning with all these |
I have not seen a PR for this issue so I have labeled it help wanted so that anyone can pick it up. |
This example https://github.com/PowerShell/xWebAdministration#registering-php should be moved to the Examples folder. Preferably in the root of the Examples folder as an end-to-end example.
Please note that examples are tested so they can be compiled.
The text was updated successfully, but these errors were encountered: