-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inclusion in Hyper-V cluster #210
Open
nyanhp
wants to merge
8
commits into
dsccommunity:main
Choose a base branch
from
nyanhp:clusterrole
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests successfully passed, code coverage could not be reported |
nyanhp
force-pushed
the
clusterrole
branch
3 times, most recently
from
April 20, 2023 09:37
586fed6
to
f04fab3
Compare
This reverts commit 6112708.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
===================================
Coverage 83% 83%
===================================
Files 11 11
Lines 1441 1464 +23
===================================
+ Hits 1203 1223 +20
- Misses 238 241 +3
|
Looks like I came here after you fixed all your issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Attempting to add cluster-awareness. Was unable to get a local build to run on (and found no info how to do it):
While the added code worked in my own lab and on site in the customer environment, I have no idea if tests will work, as some test cases for other resources randomly kept failing. So, apologies in advance. As a suggestion, a little 'How-to run a local build' would be appreciated.
Adding VMs to a cluster requires usage of PsDscRunAsCredential.
This Pull Request (PR) fixes the following issues
None
Task list
Entry should say what was changed and how that affects users (if applicable), and
reference the issue being resolved (if applicable).
This change is