Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jberezanski
Copy link

@jberezanski jberezanski commented Jun 5, 2021

Pull Request (PR) description

The Get-NetworkInformation function does not work for a ManagementOS
adapter and should not be called in that code path in Get-TargetResource.

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

The Get-NetworkInformation function does not work for a ManagementOS
adapter and should not be called in that code path in Get-TargetResource.
@jberezanski
Copy link
Author

It seems the unit tests are completely broken, possibly due to breaking changes in Pester 5.x. And even if they were correct syntacticaly, most of the tests of this resource contain logic flaws.
I can attempt to fix this, but it will take some time.

@johlju
Copy link
Member

johlju commented Jun 8, 2022

We have renamed the resource, removing 'x', so please rebase this PR.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jun 8, 2022
@johlju johlju changed the title xVMNetworkAdapter: Fix Get- failing for a ManagementOS adapter VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter Jun 8, 2022
@jberezanski
Copy link
Author

I never noticed the resource rename until now. I'll rework this PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants