Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Adding ReverseDSC Support to the module #174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NikCharlebois
Copy link

@NikCharlebois NikCharlebois commented Sep 12, 2019

Pull Request (PR) description

This PR introduces support for ReverseDSC inside the module to allow users to Reverse Engineer existing Hyper-V host and extract DSC configuration scripts out of them. It introduces the foundation required for ReverseDSC and currently only supports xVHD.

This Pull Request (PR) fixes the following issues

N/A

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #174 into dev will decrease coverage by 1%.
The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #174   +/-   ##
===================================
- Coverage    73%    72%   -2%     
===================================
  Files        11     11           
  Lines      1401   1427   +26     
===================================
  Hits       1035   1035           
- Misses      366    392   +26

@aromano2
Copy link

Hi Nik, thanks for your contribution! Can you please open an issue for this work so we have more information as to what is being added here? Can you also please work on adding tests and examples for the new functions?

@aromano2 aromano2 added breaking change When used on an issue, the issue has been determined to be a breaking change. on hold The issue or pull request has been put on hold by a maintainer. labels Jan 30, 2020
@aromano2 aromano2 changed the title Adding ReverseDSC Support to the module BREAKING CHANGE: Adding ReverseDSC Support to the module Jan 30, 2020
@johlju johlju changed the base branch from dev to master March 19, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. on hold The issue or pull request has been put on hold by a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants