Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMNetworkAdapter: Rename embedded instance class #203

Closed
johlju opened this issue Jun 13, 2022 · 0 comments · Fixed by #205
Closed

VMNetworkAdapter: Rename embedded instance class #203

johlju opened this issue Jun 13, 2022 · 0 comments · Fixed by #205
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jun 13, 2022

The embedded instance class should be renamed to VMNetworkAdapterNetworkSettings to avoid any conflicts with other resources that could have an embedded instance with the same name.

HyperVDsc/source/DSCResources/DSC_VMNetworkAdapter/DSC_VMNetworkAdapter.schema.mof

Line 2 in b0397fb

Class NetworkSettings

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jun 13, 2022
stehlih added a commit to stehlih/xHyper-V that referenced this issue Jun 23, 2022
@stehlih
VMNetworkAdapter: Rename embedded instance class dsccommunity#203
e6feba9
@stehlih stehlih mentioned this issue Jul 15, 2022
Merged
9 tasks
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VMNetworkAdapter: fix some issues on NetworkSetting parameter stehlih/xHyper-V
1 participant
@johlju