Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureDevOpsDsc: Adds GitHub templates #2

Merged
merged 3 commits into from
Jul 7, 2020
Merged

AzureDevOpsDsc: Adds GitHub templates #2

merged 3 commits into from
Jul 7, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 5, 2020 •
edited
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 5, 2020
@johlju
Copy link
Member Author

johlju commented Jul 5, 2020

@kilasuit the tests will always fail until we get the first resource PR:ed in.

@johlju johlju requested a review from kilasuit July 5, 2020 09:04
kilasuit
kilasuit requested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@kilasuit kilasuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changes requested this looks good :-)

.github/ISSUE_TEMPLATE/Problem_with_resource.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Problem_with_resource.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Problem_with_resource.md Outdated Show resolved Hide resolved
@kilasuit kilasuit changed the base branch from master to main July 6, 2020 19:32
@kilasuit kilasuit merged commit bb12274 into dsccommunity:main Jul 7, 2020
johlju pushed a commit that referenced this pull request Jun 5, 2024
@ZanattaMichael
BREAKING CHANGE - CORE 'Add Azure DevOps Managed Identity Support' (#2)
afecb3e 
* Adding Initial Class

* Creating ManagedIdentityToken class.
Expanding ManagedIdentityClass
Updated Invoke-AZDevOpsAPIRestMethod with ManagedIdentity Handeler

* Refactoring 004.AzManagedIdentity into Functions
Added APIRateLimit Enum

* Renaming DataResources
Updating AzureDevOpsDsc.Common.psd1
Initial ompleted Managed Identity Cmdlets.

* Adding Initial Tests

* Fixing Documentation
Adding Unit Tests

* Moving Tests
Completed ManagedIdentityToken Test

* Completed APIRateLimit Unit Testing

* Bug Fixes on Azure VM to get Managed Identity Working

* Updating Tests

* Fixing Tests

* Test Updates

* Updating Paths

* Update Paths

* Bug fixes with build and testing process

* Fixing Headers

* Bug Fixes with the Token

* Bug Fixes

* More bug fixes

* Fixing Bugs

* Updated Documentation and ChangeLog to bring into line with guidelines.

---------

Co-authored-by: Michael Zanatta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilasuit kilasuit kilasuit requested changes

Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AzureDevOpsDsc: Add GitHub issue templates and pull request templates
2 participants
@johlju @kilasuit