Change strongbranching pseudo_candidate default #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasse
reviewed
Sep 9, 2021
There was a problem hiding this comment.
Looks good to me. However, shouldn't that be merged into dev to target the next major minor (Edit @AntoinePrv) release ?
|
Isn't this a bug fix for |
|
It's API breaking, it will require users to update their code. I would rather wait for the end of the competition before making such a change. |
|
The idea being that we keep the 7.0.x releases for bugfixes related to the competition. |
|
Indeed. So guess you don't want this for the competition. |
AntoinePrv
force-pushed
the
fix-pseudo-candidates
branch
from
9874a99 to
d2faddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Proposed implementation