-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract reward before observation (C++ and Python) #212
Conversation
I reordered reward, observation everywhere to be consistent (even in the constructor where it does not matter). The tests seem to pass, at least on my machine. @AntoinePrv can you check the code for C++ (great)ness ? |
All CI tests pass now. Good to go ? |
There is a long commit history that does not seem to belong to this PR. |
Oh no, I though I had merged that one before the release :O @AntoinePrv that's because I have rebased dev onto master. I've rebased this PR as well, should look better now. |
I guess v0.7.0 will have a very short life... |
Thanks for the code review ! I'll make the changes ASAP. |
I removed the @dchetelat @AntoinePrv let me know how that looks to you now. |
Ah it looks like some conflicting commits have not been handled correctly when I rebased |
Yeah I feel it's the third time we fix that lol. Rebasing chaos... |
See #209