Local files instance loader #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
feature-instance-loader
branch
from
0a7614a to
bda55cc
Compare
AntoinePrv
force-pushed
the
feature-instance-loader
branch
from
bda55cc to
21587d8
Compare
This reverts commit 3f082eb.
AntoinePrv
force-pushed
the
feature-instance-loader
branch
from
21587d8 to
225cd7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Proposed implementation
So far an instance loader that iterates over regular files (no glob/filter).
It does not set any scip parameters.
@gasse @dchetelat It was a bit hard to design tests for it (because you need a local dataset...), so if you want to take it for a spin, make sure that everything is OK, that'd be great.