Good instance generator defaults #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
generators_to_learn2branch
branch
from
60376cc to
a3ed74a
Compare
AntoinePrv
force-pushed
the
generators_to_learn2branch
branch
from
a3ed74a to
5158311
Compare
|
@dchetelat is good to merge? Seems that with #150 it solves the issue. |
|
Yes you're right, I thought Maxime would add a commit to this PR but he seems to have created his own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the generators so that the defaults match the way instances were generated in the learn2branch paper (or at least, that they have reasonable difficulty.)
Pull request checklist