Merge pull request eclipse-tractusx#518 from catenax-ng/feature/TRI-X…

…XX-fix-critical-findings feat(impl):[TRI-XXX] fix criticals
ds-jhartmann · Sep 5, 2023 · 2691af2 · 2691af2
2 parents b6516c7 + f609b49
commit 2691af2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/irs-api/src/main/java/org/eclipse/tractusx/irs/semanticshub/SemanticsHubClient.java b/irs-api/src/main/java/org/eclipse/tractusx/irs/semanticshub/SemanticsHubClient.java
@@ -246,8 +246,8 @@ private Optional<String> readFromSemanticHub(final String urn) {
             try {
                 final UriComponentsBuilder uriBuilder = UriComponentsBuilder.fromUriString(
                         config.getModelJsonSchemaEndpoint());
-                final Map<String, String> values = Map.of(PLACEHOLDER_URN, urn);
-                return Optional.ofNullable(restTemplate.getForObject(uriBuilder.build(values), String.class));
+                uriBuilder.uriVariables(Map.of(PLACEHOLDER_URN, urn));
+                return Optional.ofNullable(restTemplate.getForObject(uriBuilder.build().toUri(), String.class));
             } catch (final RestClientException e) {
                 log.error("Unable to retrieve schema from semantic hub for urn '{}'", urn, e);
             }

diff --git a/...n/java/org/eclipse/tractusx/irs/registryclient/central/DigitalTwinRegistryClientImpl.java b/...n/java/org/eclipse/tractusx/irs/registryclient/central/DigitalTwinRegistryClientImpl.java
@@ -98,8 +98,8 @@ public AssetAdministrationShellDescriptor getAssetAdministrationShellDescriptor(
     public LookupShellsResponse getAllAssetAdministrationShellIdsByAssetLink(
             final List<IdentifierKeyValuePair> assetIds) {
         final UriComponentsBuilder uriBuilder = UriComponentsBuilder.fromUriString(shellLookupEndpoint);
-        final var values = Map.of(PLACEHOLDER_ASSET_IDS, StringMapper.mapToString(assetIds));
-        return restTemplate.exchange(uriBuilder.build(values), HttpMethod.GET, null, LookupShellsResponse.class)
+        uriBuilder.uriVariables(Map.of(PLACEHOLDER_ASSET_IDS, StringMapper.mapToString(assetIds)));
+        return restTemplate.exchange(uriBuilder.build().toUri(), HttpMethod.GET, null, LookupShellsResponse.class)
                            .getBody();
     }
 

diff --git a/...org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryClient.java b/...org/eclipse/tractusx/irs/registryclient/decentral/DecentralDigitalTwinRegistryClient.java
@@ -80,8 +80,8 @@ public LookupShellsResponse getAllAssetAdministrationShellIdsByAssetLink(
             final EndpointDataReference endpointDataReference, final List<IdentifierKeyValuePair> assetIds) {
         final String shellLookupEndpoint = endpointDataReference.getEndpoint() + lookupShellsTemplate;
         final UriComponentsBuilder uriBuilder = UriComponentsBuilder.fromUriString(shellLookupEndpoint);
-        final var values = Map.of(PLACEHOLDER_ASSET_IDS, StringMapper.mapToString(assetIds));
-        return edcRestTemplate.exchange(uriBuilder.build(values), HttpMethod.GET,
+        uriBuilder.uriVariables(Map.of(PLACEHOLDER_ASSET_IDS, StringMapper.mapToString(assetIds)));
+        return edcRestTemplate.exchange(uriBuilder.build().toUri(), HttpMethod.GET,
                 new HttpEntity<>(null, headers(endpointDataReference)), LookupShellsResponse.class).getBody();
     }