Merge pull request #83 from dry-rb/setting_str_sym

Store settings as symbol and fetch them from symbol or string

[changelog]

version: 0.11.3
fixed: "Retrieving settings by a string name works again (issue #82) (@waiting-for-dev)"

lib/dry/configurable/config.rb

@@ -33,6 +33,7 @@ def initialize(settings)
       #
       # @return Config value
       def [](name)
+        name = name.to_sym
         raise ArgumentError, "+#{name}+ is not a setting name" unless _settings.key?(name)
 
         _settings[name].value

lib/dry/configurable/dsl.rb

@@ -43,7 +43,7 @@ def setting(name, *args, &block)
 
         default, opts = args
 
-        node = [:setting, [name, default, opts == default ? EMPTY_HASH : opts]]
+        node = [:setting, [name.to_sym, default, opts == default ? EMPTY_HASH : opts]]
 
         if block
           if block.arity.zero?

spec/integration/dry/configurable/config_spec.rb

@@ -113,6 +113,12 @@
   end
 
   describe '#[]' do
+    it 'coerces name from string' do
+      klass.setting :db, :sqlite
+
+      expect(klass.config['db']).to eql(:sqlite)
+    end
+
     it 'raises ArgumentError when name is not valid' do
       expect { klass.config[:hello] }.to raise_error(ArgumentError, /hello/)
     end

spec/integration/dry/configurable/setting_spec.rb

@@ -38,6 +38,12 @@
       )
     end
 
+    it 'stores setting name as symbol' do
+      klass.setting 'db', 'sqlite'
+
+      expect(object.config.values.keys).to include(:db)
+    end
+
     context 'with a default value' do
       context 'string' do
         before do