Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#69): add debug mode and axios logging #388

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Dec 1, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021

🦋 Changeset detected

Latest commit: 78d36da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
druxt Minor
druxt-blocks Patch
druxt-breadcrumb Patch
druxt-entity Patch
druxt-menu Patch
druxt-router Patch
druxt-schema Patch
druxt-site Patch
druxt-test-utils Major
druxt-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #388 (78d36da) into develop (39e2e2e) will decrease coverage by 0.16%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #388      +/-   ##
===========================================
- Coverage    97.07%   96.91%   -0.17%     
===========================================
  Files           89       89              
  Lines         2874     2884      +10     
  Branches       625      626       +1     
===========================================
+ Hits          2790     2795       +5     
- Misses          76       81       +5     
  Partials         8        8              
Impacted Files Coverage Δ
packages/druxt/src/client.js 92.00% <72.72%> (-3.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e2e2e...78d36da. Read the comment docs.

@Decipher
Copy link
Member Author

Decipher commented Dec 1, 2021

Currently it doesn't seem possible to test the axios interceptors, but I'm going to merge this anyway as it's a low risk feature.

@Decipher Decipher merged commit 85fff42 into develop Dec 1, 2021
@Decipher Decipher deleted the feature/69-debug_consola branch December 1, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide verbose debug data
1 participant