Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3417. sql-sync dump filename not automatically generated #3418

Merged
merged 3 commits into from
Feb 27, 2018
Merged

Conversation

weitzman
Copy link
Member

One downside of this fix is that running this code with a prior version of Drush will cause your dump files to be names auto instead of date based backups. I think mismatched Drush versions are a lot less common now that we are local to the project.

@weitzman weitzman mentioned this pull request Feb 27, 2018
@weitzman
Copy link
Member Author

weitzman commented Feb 27, 2018

I will add that sql:sync should be working even without this fix so I'm not sure whats going on in the BLT test failure. Our sql:sync tests have been passing and they dont pass --result-file. Could you try with this one line change and see if sql:sync starts succeeding?

@greg-1-anderson
Copy link
Member

'result-file' => true should make backend invoke use --result-file; maybe some bug is causing it to insert --result-file=1 instead?

The => NULL trick is only for unish, if I recall correctly.

@weitzman
Copy link
Member Author

Could be ... But --result-file without a value is now invalid. That option requires a value. I just pushed a commit which documents this. This change went in at #3370.

@grasmash
Copy link
Contributor

I can verify that this does resolve the initial issue, and causes acquia/blt tests to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants