GH-10: PHP8 compatibility. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrenssen
reviewed
Feb 1, 2022
README.md
Outdated
Comment on lines
24
to
25
| * [PHP 7.1](http://php.net/) | ||
| * [Drupal 8.6](https://www.drupal.org/) | ||
| * [PHP 8.0](http://php.net/) | ||
| * [Drupal 9.2](https://www.drupal.org/) |
There was a problem hiding this comment.
What is introduced here that would break backwards compatibility with PHP 7.1 and Drupal 8.6? I don't see any changes to the PHP code so this should continue to work fine.
pfrenssen
reviewed
Feb 1, 2022
composer.json
Outdated
Comment on lines
52
to
57
| "composer/installers": true, | ||
| "cweagans/composer-patches": true, | ||
| "dealerdirect/phpcodesniffer-composer-installer": true, | ||
| "drupal/core-composer-scaffold": true, | ||
| "phpro/grumphp": true | ||
| }, |
There was a problem hiding this comment.
Why would we allow things like composer-patches and grumphp? We're not using those.
pfrenssen
approved these changes
Feb 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.