Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge new vertices when drp is missing #460

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: merge new vertices when drp is missing #460

wants to merge 2 commits into from

Conversation

trungnotchung
Copy link
Member

@trungnotchung trungnotchung commented Feb 12, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • remove function mergeWithoutDrp
  • update logic when store drp state and acl state to make code more readable
  • check if the drp exists before apply operation and store/update drp state
  • update _checkWriterPermission because we still have the acl state even if the drp is missing

Related Issues and PRs

Added/updated tests?

  • Yes
  • No, because why: just merged two functions. current tests covered all the cases
  • I need help with writing tests

Additional Info

add instructions or screenshots on what you might think is relevant or instructions on how to manually test it

[optional] Do we need to perform any post-deployment tasks?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Flamegraph.com report

flamegraph.pprof
See in flamegraph.com

Created by Flamegraph.com Github Action

@trungnotchung trungnotchung changed the title remove mergeWithoutDrp fix: remove mergeWithoutDrp Feb 12, 2025
@trungnotchung trungnotchung changed the title fix: remove mergeWithoutDrp fix: merge new vertices when drp is missing Feb 12, 2025
@trungnotchung trungnotchung marked this pull request as ready for review February 12, 2025 17:19
winprn
winprn approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@winprn winprn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anhnd350309
anhnd350309 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@anhnd350309 anhnd350309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winprn winprn winprn approved these changes

@anhnd350309 anhnd350309 anhnd350309 approved these changes

@JanLewDev JanLewDev Awaiting requested review from JanLewDev JanLewDev is a code owner

@hoangquocvietuet hoangquocvietuet Awaiting requested review from hoangquocvietuet hoangquocvietuet is a code owner

@magnified103 magnified103 Awaiting requested review from magnified103 magnified103 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update ACL and ACL State when drp is missing
3 participants
@trungnotchung @winprn @anhnd350309