fix: duplicate DRP call #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoangquocvietuet
requested review from
JanLewDev,
trungnotchung,
winprn and
magnified103
as code owners
Signed-off-by: Sacha Froment <[email protected]>
sfroment
force-pushed
the
fix/duplicate-drp-call
branch
from
b6e40e3 to
b42cc8b
Compare
sfroment
reviewed
Feb 5, 2025
Co-authored-by: Sacha Froment <[email protected]>
Comment on lines
+197
to
+199
| const computeFn = isACL ? this._computeObjectACL : this._computeDRP; | ||
| const vertexDependencies = this.hashGraph.getFrontier(); | ||
| const preOperationDRP = computeFn(vertexDependencies); |
There was a problem hiding this comment.
why don't you call these functions directly instead of defining a new variable computeFn. it just makes the code harder to understand
There was a problem hiding this comment.
I don't agree with this statement, but we can still discuss about it
There was a problem hiding this comment.
it remove and if else and also remove the fact that we have to add a let var
There was a problem hiding this comment.
this way is more js idiomatic, in js the more you are functional the better it is .
Overall the less mutation you have the better, also the more reliability and readability you'll have
There was a problem hiding this comment.
i mean:
const preOperationDRP = isACL ? this._computeObjectACL(vertexDependencies) : this._computeDRP(vertexDependencies);
Comment on lines
+160
to
+161
| const appliedOperationResult = obj.callFn(fullPropKey, args, vertexType); | ||
| return appliedOperationResult; |
There was a problem hiding this comment.
Suggested change
| const appliedOperationResult = obj.callFn(fullPropKey, args, vertexType); | |
| return appliedOperationResult; | |
| return obj.callFn(fullPropKey, args, vertexType); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved: #404