This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Update ios version in Make targets to 10.1. #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automated message from Dropbox CLA bot @csimmons0, it looks like you've already signed the Dropbox CLA. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Slack discussion channel: https://mobilecpp.slack.com/archives/general/p1478766914000338
In short, the Makefiles say that the iOS targets need to run on a simulator that's running ios 9.3, which causes the iOS targets to fail if you have the latest version of Xcode installed. This change updates the Makefiles to specify ios 10.1.