Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 #393

wants to merge 1 commit into from

Conversation

Narendra-Neerukonda
Copy link

@Narendra-Neerukonda Narendra-Neerukonda commented Jun 18, 2021 •
edited
Loading

Filled out the Dropbox Contributor License Agreement
Fixes #392

@Narendra-Neerukonda Narendra-Neerukonda mentioned this pull request Jun 18, 2021
Open
tirkarthi
tirkarthi reviewed Jun 19, 2021
View reviewed changes
pyhive/common.py
@@ -12,11 +12,14 @@
from past.builtins import basestring
from pyhive import exc
import abc
import collections
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file still uses deque from collections at

PyHive/pyhive/common.py

Line 41 in d6e7140

self._data = collections.deque()
. This import should not be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted to "import collections" and changed import at Iterable statement as collections.abc.Iterable

@Narendra-Neerukonda Narendra-Neerukonda changed the title import iterable from collection.abc instead of collections import iterable from collection.abc instead of collections to clear deprecation warning in python 3.10 Jun 19, 2021
@admackin
Copy link

This PR seems like it would be really handy as it would allow pyhive to be compatible with python 3.10. Any chance of it getting merged?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@fabiofalavinha
Copy link

What's the ETA to merge this pull request?

@fabiofalavinha
Copy link

As a workaround, I just added the code on my python script:

if "3.10" in sys.version:
    collections.Iterable = collections.abc.Iterable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections has been removed in Python 3.10 in favor of collections.abc
5 participants
@Narendra-Neerukonda @admackin @CLAassistant @fabiofalavinha @tirkarthi