Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added UDP multicast support #41

Merged
merged 2 commits into from
Jul 3, 2023
Merged

added UDP multicast support #41

merged 2 commits into from
Jul 3, 2023

Conversation

tridge
Copy link
Member

@tridge tridge commented Jun 12, 2023 •
edited
Loading

this allows for both bxCAN and CANFD packets to be sent over UDP multicast

multicast address is 239.65.82.B, last octet is logical bus number
UDP port number is 57732

packet format is

  • MAGIC 0x2934 16 bit
  • 16 bit CCITT CRC over all bytes after CRC
  • 16 bit flags
  • 32 bit message ID
  • data[]

all data is little endian

standard URLs
mcast: -> first bus
mcast:0 -> first bus
mcast:1 -> 2nd bus

@tridge tridge requested a review from bugobliterator June 12, 2023 01:26
@tridge tridge mentioned this pull request Jun 12, 2023
Merged
@tridge tridge force-pushed the pr-udp-multicast branch from de7bcc1 to 3d91432 Compare June 12, 2023 02:58
@magicrub
Copy link

Is this something we want to add to the initial networking PR?

@tridge tridge force-pushed the pr-udp-multicast branch from 3d91432 to 41e4a5b Compare June 21, 2023 04:34
@tridge
Copy link
Member Author

tridge commented Jun 21, 2023

Is this something we want to add to the initial networking PR?

I think it should be separate, I want to get it into libcanard, pydronecan and GUI tool first

@tridge tridge mentioned this pull request Jun 23, 2023
Merged
bugobliterator
bugobliterator previously requested changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@bugobliterator bugobliterator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A checksum might be a good idea to add so as to confirm that we are talking CAN protocol.

tridge added 2 commits July 3, 2023 14:10
@tridge
added UDP multicast support
e735a48 
this allows for both bxCAN and CANFD packets to be sent over UDP
multicast
@tridge
driver: ensure data in CANFrame is a byte array
1d88a0e
@tridge tridge force-pushed the pr-udp-multicast branch from 41e4a5b to 1d88a0e Compare July 3, 2023 04:11
@tridge tridge merged commit 3051152 into dronecan:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugobliterator bugobliterator bugobliterator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tridge @magicrub @bugobliterator