Add PCAN support through python-can #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetervdPerk-NXP
force-pushed
the
pcan_windows
branch
from
f4756c3 to
f5df4f2
Compare
tridge
requested changes
Dec 20, 2022
dronecan_gui_tool/setup_window.py
Outdated
| @@ -105,6 +105,11 @@ def list_ifaces(): | |||
| for x in mifaces: | |||
| out[x] = x | |||
|
|
|||
| from can import detect_available_configs | |||
There was a problem hiding this comment.
I think we need a try except around this, to cope with systems without the can python module
There was a problem hiding this comment.
i've added the exception check, can you test?
There was a problem hiding this comment.
Tested with try except without python-can installed on windows seems to be working fine.
tridge
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dronecan/pydronecan#25
Iterates python-can compatible PCAN interfaces and adds to them to ifaces list.
Tested on Windows.