Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CompareChanges function to GitService. #38

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

chhsia0
Copy link
Contributor

@chhsia0 chhsia0 commented Oct 1, 2019

CompareChanges returns the changeset between two commits. If the source commit is not an ancestor of the target commit, it is up to the driver to return a 2-way or 3-way diff changeset.

CompareChanges returns the changeset between two
commits. If the source commit is not an ancestor
of the target commit, it is up to the driver to
return a 2-way or 3-way diff changeset.
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

@chhsia0
Copy link
Contributor Author

chhsia0 commented Oct 1, 2019

@bradrydzewski Would you mind taking a look at this PR? Thanks :)

@bradrydzewski
Copy link
Member

@chhsia0 thanks! I really appreciate that you included extensive testing and support for as many providers as possible :)

@bradrydzewski bradrydzewski merged commit 71b214b into drone:master Oct 4, 2019
@tboerger
Copy link
Contributor

tboerger commented Oct 4, 2019

As Gitea supports a diff view between branches I'm pretty sure there must also be an API for it. @lunny or @appleboy, maybe somebody of you could jump in with a followup pr?

@lunny
Copy link
Contributor

lunny commented Oct 5, 2019

@tboerger will try this.

@lunny
Copy link
Contributor

lunny commented Oct 5, 2019

I think we have an issue for that and need a PR. go-gitea/gitea#5561

jstrachan pushed a commit to jstrachan/go-scm that referenced this pull request Oct 17, 2019
fix: add support for passing the GitHub App installation header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants