feat: [CI-14214] : Added PLUGIN_USER_ROLE_EXTERNAL_ID to pass external ID for the secondary role when required. #174

DevanshMathur19 · 2024-10-15T07:53:52Z

No description provided.

main.go

plugin.go

Removing testing code. Co-authored-by: OP (oppenheimer) <[email protected]>

Removing loggers. Co-authored-by: OP (oppenheimer) <[email protected]>

README.md

…3-dm into CI-14214 Merging updates.

plugin.go

Ompragash

LGTM

README.md

test change to trigger CI job

Ompragash · 2024-10-30T16:16:37Z

plugins/s3 was extensively tested for the following scenarios, and the behavior works as expected:

Using AWS access key and secret key. (without cross account access). ✅ Execution Link
Using AWS access key and secret key. (with cross account access). ✅ Execution Link
Assume IAM role on Delegate. (without cross account access). ✅ Execution Link
Assume IAM role on Delegate. (with cross account access). ✅ Execution Link
Using IRSA (without cross account access). ✅ Execution Link
Using IRSA (with cross account access). ✅ Execution Link
Use OIDC ✅ Execution Link

These changes also include fixes for both CI-14887 and CI-14134

DevanshMathur19 added 3 commits October 15, 2024 13:10

feat : [CI-14214]: PLUGIN_USER_ROLE_EXTERNAL_ID added.

ef0ed67

Updated manifest.tmpl

4347730

Updated manifest.tmpl

ddcc163

Ompragash requested changes Oct 29, 2024

View reviewed changes

main.go Outdated Show resolved Hide resolved

main.go Outdated Show resolved Hide resolved

plugin.go Outdated Show resolved Hide resolved

plugin.go Outdated Show resolved Hide resolved

DevanshMathur19 and others added 6 commits October 29, 2024 16:49

Update main.go

c5c1a9f

Removing testing code. Co-authored-by: OP (oppenheimer) <[email protected]>

Update main.go

97e75f9

Removing loggers. Co-authored-by: OP (oppenheimer) <[email protected]>

Update plugin.go

c442b27

Removing loggers. Co-authored-by: OP (oppenheimer) <[email protected]>

Update plugin.go

b552b3b

Removing loggers. Co-authored-by: OP (oppenheimer) <[email protected]>

Updating README

dc409a5

Remove excessive logging.

4195d90

Ompragash reviewed Oct 29, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Ompragash and others added 6 commits October 29, 2024 21:05

Update README.md

8c455b1

Update README.md

4535bdf

Fixing CI-14887 and CI-14134

fca1a37

Merge branch 'CI-14214' of https://github.com/DevanshMathur19/drone-s…

2eb5d43

…3-dm into CI-14214 Merging updates.

Fixing CI-14887 and CI-14134

91a4e90

Testing with AWS KEYS withour second session.

6852d94

Ompragash reviewed Oct 30, 2024

View reviewed changes

plugin.go Outdated Show resolved Hide resolved

Ompragash added 2 commits October 30, 2024 18:33

Update plugin.go

cd350f2

Merge branch 'master' into CI-14214

e8c1c05

Ompragash approved these changes Oct 30, 2024

View reviewed changes

README.md Show resolved Hide resolved

Update README.md

cc674ad

Ompragash approved these changes Oct 30, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

f18a7c0

test change to trigger CI job

Ompragash merged commit 665db05 into drone-plugins:master Oct 30, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [CI-14214] : Added PLUGIN_USER_ROLE_EXTERNAL_ID to pass external ID for the secondary role when required. #174

feat: [CI-14214] : Added PLUGIN_USER_ROLE_EXTERNAL_ID to pass external ID for the secondary role when required. #174

DevanshMathur19 commented Oct 15, 2024

Ompragash left a comment

Ompragash commented Oct 30, 2024

feat: [CI-14214] : Added PLUGIN_USER_ROLE_EXTERNAL_ID to pass external ID for the secondary role when required. #174

feat: [CI-14214] : Added PLUGIN_USER_ROLE_EXTERNAL_ID to pass external ID for the secondary role when required. #174

Conversation

DevanshMathur19 commented Oct 15, 2024

Ompragash left a comment

Choose a reason for hiding this comment

Ompragash commented Oct 30, 2024