Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ECR & GCR docker publish on windows #352

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Fix ECR & GCR docker publish on windows #352

merged 3 commits into from
Jan 12, 2022

Conversation

shubham149
Copy link

No description provided.

@shubham149 shubham149 requested a review from tphoney January 11, 2022 15:47
@tphoney
Copy link

tphoney commented Jan 12, 2022

Looks good, can you squash the commits on merge.

@shubham149 shubham149 merged commit 47dc855 into master Jan 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the win_ecr branch January 12, 2022 17:03
@eoinmcafee00 eoinmcafee00 added the bug Something isn't working label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tphoney tphoney tphoney approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham149 @tphoney @eoinmcafee00