Main 화면 네비게이션 구조 feature 모듈을 의존하는 형태로 개선 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisemuji
approved these changes
Jul 19, 2023
Comment on lines
+18
to
+20
| object HomeRoute { | ||
| const val route = "home" | ||
| } |
There was a problem hiding this comment.
단순 상수값으로도 충분하다고 생각했는데 HomeRoute가 object여야할 이유가 있을까요?
There was a problem hiding this comment.
@wisemuji
Route를 만들어주는 역할을 하는 목적으로 보면 object로 관리하는 이점이 있습니다.
ref : https://github.com/DroidKaigi/conference-app-2022/blob/main/feature/sessions/src/main/java/io/github/droidkaigi/confsched2022/feature/sessions/SessionsNavGraph.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
기타 작업사항
1.7.0버전에서 컴포즈 UI 테스트가 깨지는 문제가 있어 버전을1.7.2로 업데이트 함