[feature/#300] Apply Type Safe Navigation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results18 tests 18 ✅ 5s ⏱️ Results for commit ee817b8. ♻️ This comment has been updated with latest results. |
wisemuji
reviewed
May 30, 2024
Comment on lines
5
to
7
| interface Route | ||
|
|
||
| interface MainTabRoute : Route |
There was a problem hiding this comment.
sealed interface를 활용하여 컴파일러에게 구현된 타입을 알려주면 어떨까요?
Route, MainTabRoute별로 subclass를 묶어두면 가독성도 좋아질 것 같아요
|
|
[feature/droidknights#300] Apply code review
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
시연 영상
Screen_recording_20240530_115044.mp4