-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(FEAT)[#294] UI 코드 정리 #295
Conversation
Test Results18 tests 18 ✅ 5s ⏱️ Results for commit 5c859dd. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니당~!
@@ -109,6 +114,7 @@ private fun BookmarkScreen( | |||
items = bookmarkItems, | |||
key = { item -> item.session.id } | |||
) { itemState -> | |||
/** 편집모드 나타내는 Trailing 컨텐츠를 이곳에 구현하세요 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
onSessionClick = {}, | ||
onContributorClick = {}, | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF가 나고 있습니다 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하! 엔터가 (개인적으론 안쓰고 있어서)
|
||
@Immutable | ||
data class Sponsors( | ||
val sponsors: ImmutableList<Sponsor>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SponsorScreenTest도 수정되어야 할 것 같아요 🙂
@@ -1,13 +1,15 @@ | |||
package com.droidknights.app.feature.home | |||
package com.droidknights.app.feature.home.model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PreviewParameter도 model로 간주하셨군요 😮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모델이긴 한데 요건 밖으로 뺄게요 ㅎㅎ 정의한 부분이라서 애매한?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😆
Issue
Overview (Required)