Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FEAT)[#294] UI 코드 정리 #295

Merged
merged 3 commits into from
May 22, 2024
Merged

(FEAT)[#294] UI 코드 정리 #295

merged 3 commits into from
May 22, 2024

Conversation

taehwandev
Copy link
Member

Issue

Overview (Required)

  • UI 패키지 구조 변경
    • component : UI 아이템들 모음
    • model : 데이터 모음
  • 그외 코드 정리

@taehwandev taehwandev self-assigned this May 21, 2024
@taehwandev taehwandev changed the title 2024/feature/ref (FEAT)[#294] UI 코드 정리 May 21, 2024
Copy link

github-actions bot commented May 21, 2024

Test Results

18 tests   18 ✅  5s ⏱️
11 suites   0 💤
11 files     0 ❌

Results for commit 5c859dd.

♻️ This comment has been updated with latest results.

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당~!

@@ -109,6 +114,7 @@ private fun BookmarkScreen(
items = bookmarkItems,
key = { item -> item.session.id }
) { itemState ->
/** 편집모드 나타내는 Trailing 컨텐츠를 이곳에 구현하세요 */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

onSessionClick = {},
onContributorClick = {},
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF가 나고 있습니다 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하! 엔터가 (개인적으론 안쓰고 있어서)


@Immutable
data class Sponsors(
val sponsors: ImmutableList<Sponsor>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SponsorScreenTest도 수정되어야 할 것 같아요 🙂

@@ -1,13 +1,15 @@
package com.droidknights.app.feature.home
package com.droidknights.app.feature.home.model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreviewParameter도 model로 간주하셨군요 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모델이긴 한데 요건 밖으로 뺄게요 ㅎㅎ 정의한 부분이라서 애매한?

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😆

@taehwandev taehwandev merged commit 9c02728 into main May 22, 2024
2 checks passed
@taehwandev taehwandev deleted the 2024/feature/ref branch June 10, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants