[Bug] 오픈소스 라이센스 카드 클릭 시 카드 영역 밖으로 리플 효과 나타나지 않도록 수정 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisemuji
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview (Required)
modifier.clickable을 통해OssLicensesMenuActivity로 이동하고 있어 아래의 사진과 같이 카드 영역 밖으로Ripple효과가 생기는 것을 발견하였습니다.이는 사용자 경험에 문제가 있을 수 있다고 판단하여,
KnightsCard의onClick으로OssLicensesMenuActivity로 이동하도록 수정하였습니다.Links
none
Screenshot