Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placeholder 이미지 사진 core-ui 모듈 이동 #237

Merged
merged 14 commits into from
Aug 25, 2023
Merged

placeholder 이미지 사진 core-ui 모듈 이동 #237

merged 14 commits into from
Aug 25, 2023

Conversation

Cjsghkd
Copy link
Contributor

@Cjsghkd Cjsghkd commented Aug 23, 2023

Issue

Overview (Required)

  • designsystem -> core-ui 모듈로 placholder 이미지 사진 이동

@github-actions
Copy link

github-actions bot commented Aug 23, 2023 •
edited
Loading

Test Results

18 tests   18 ✔️  8s ⏱️
11 suites    0 💤
11 files      0 ❌

Results for commit 0219e22.

♻️ This comment has been updated with latest results.

@Cjsghkd
Copy link
Contributor Author

Cjsghkd commented Aug 24, 2023

@wisemuji
오류를 해결하면서 지금은 사용을 안해서 designsystem <- core-ui 로 참조되던 것을 반대로 바꿨는데,
혹시 designsystem이 core-ui에 사용될 예정인가요?

wisemuji
wisemuji requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 🙇
몇 가지 코멘트 확인 부탁드립니다.

core/designsystem/build.gradle.kts Outdated Show resolved Hide resolved
core/ui/src/main/res/drawable-xxxhdpi/placeholder_speaker.png Outdated Show resolved Hide resolved
@Cjsghkd
Copy link
Contributor Author

Cjsghkd commented Aug 24, 2023

@wisemuji 넵! 수정했습니다!

wisemuji
wisemuji approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다! 고생 많으셨습니다 👏

@wisemuji wisemuji merged commit d5be5e1 into droidknights:main Aug 25, 2023
@Cjsghkd Cjsghkd deleted the cjsghkdfeature/#140 branch August 25, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisemuji wisemuji wisemuji approved these changes

Assignees

@Cjsghkd Cjsghkd

Labels
2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

placeholder 이미지 사진 core-ui 모듈 이동
3 participants
@Cjsghkd @wisemuji @taehwandev