Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/#17] Add Type-safe project accessors #214

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

l2hyunwoo
Copy link
Contributor

Issue

Overview (Required)

  • Gradle의 Type-safe project accessor preview 환경설정을 추가한다.
  • 현재 rootProject.name이 DroidKnights 2023과 같이 공백이 있어서 옵션을 추가할 때 빌드 에러가 발생했습니다. 따라서 이번 PR에서 임의로 rootProject의 name을 DroidKnights_2023로 변경하였습니다.

Links

@github-actions
Copy link

github-actions bot commented Aug 16, 2023

Test Results

13 tests   13 ✔️  7s ⏱️
  9 suites    0 💤
  9 files      0

Results for commit 52a0acb.

♻️ This comment has been updated with latest results.

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l2hyunwoo 첫 기여 PR을 올려주셨군요! 🎉
코멘트 확인 부탁드립니다.

settings.gradle.kts Outdated Show resolved Hide resolved
settings.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 👏 첫 기여 PR 머지 축하드립니다!

@wisemuji wisemuji merged commit da860ae into droidknights:main Aug 17, 2023
@l2hyunwoo l2hyunwoo deleted the feature/#17 branch August 17, 2023 12:41
@l2hyunwoo l2hyunwoo restored the feature/#17 branch August 17, 2023 12:41
@l2hyunwoo l2hyunwoo deleted the feature/#17 branch August 17, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[build-logic] Type-safe project dependencies on Gradle
3 participants