Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

비어있는 데이터를 출력하기 위한 에셋 추가 #200

Merged
merged 1 commit into from
Aug 15, 2023
Merged

비어있는 데이터를 출력하기 위한 에셋 추가 #200

merged 1 commit into from
Aug 15, 2023

Conversation

laco-dev
Copy link
Contributor

Issue

Overview (Required)

  • 따로 시안은 없지만 drawable 에셋으로 활용하기 위해 로고 이미지 추가합니다.

@laco-dev laco-dev requested a review from wisemuji August 15, 2023 08:37
wisemuji
wisemuji reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 에셋들은 해상도별 (drawable-hdpi 등) 대응이 필요하지 않을까요?

@laco-dev
Copy link
Contributor Author

해당 에셋들은 해상도별 (drawable-hdpi 등) 대응이 필요하지 않을까요?

원본 이미지를 스케일링 하지 않고, 원본을 받은 상태라 따로 불필요할 것 같습니다.

@laco-dev laco-dev requested a review from wisemuji August 15, 2023 08:40
@github-actions
Copy link

Test Results

13 tests   13 ✔️  7s ⏱️
  9 suites    0 💤
  9 files      0 ❌

Results for commit 9da28f7.

@laco-dev laco-dev merged commit 3fe9173 into droidknights:main Aug 15, 2023
@laco-dev laco-dev deleted the feature/#199 branch August 15, 2023 08:43
@laco-dev laco-dev self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisemuji wisemuji wisemuji approved these changes

Assignees

@laco-dev laco-dev

Labels
2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

비어있는 데이터를 출력하기 위한 에셋 추가
3 participants
@laco-dev @wisemuji @taehwandev