Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions 단위 테스트 설정 / detekt 변경사항 반영 #176

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Github Actions 단위 테스트 설정 / detekt 변경사항 반영 #176

merged 3 commits into from
Aug 15, 2023

Conversation

wisemuji
Copy link
Member

@wisemuji wisemuji commented Aug 15, 2023 •
edited
Loading

Issue

Overview (Required)

  • turbine 의존성 이름 수정
  • forked branch에서도 github action이 동작하도록 설정
  • detekt analysis 제안 적용
    • Compose Preview에서는 경고가 보이지 않도록 하기 위해 UnusedPrivateMember 옵션을 비활성화했습니다.

@wisemuji wisemuji self-assigned this Aug 15, 2023
@wisemuji wisemuji changed the title [Draft] Github Actions 설정 Github Actions 단위 테스트 설정 / detekt 변경사항 반영 Aug 15, 2023
@wisemuji wisemuji requested a review from laco-dev August 15, 2023 02:16
@wisemuji
Copy link
Member Author

wisemuji commented Aug 15, 2023 •
edited
Loading

detekt 옵션을 다음과 같이 변경해도 괜찮을지 더블체크 부탁드립니다 🙇 @laco-dev

image

Compose Preview에서는 경고가 보이지 않도록 하기 위해 UnusedPrivateMember 옵션을 비활성화했습니다.

@wisemuji wisemuji mentioned this pull request Aug 15, 2023
Closed
@wisemuji
Copy link
Member Author

@laco-dev
다른 PR에 blocking되는 이슈라 일단 머지하고, 나중에 특이사항 생기면 따로 반영하겠습니다.

@wisemuji wisemuji merged commit 31ad666 into droidknights:main Aug 15, 2023
@wisemuji wisemuji deleted the fix/#175 branch August 15, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laco-dev laco-dev Awaiting requested review from laco-dev

Assignees

@wisemuji wisemuji

Labels
2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actions 단위 테스트 설정
2 participants
@wisemuji @taehwandev