[Home] 카드 UI 텍스트 컬러 테마 시스템 적용 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisemuji
commented
Jul 31, 2023
| @@ -60,8 +60,6 @@ internal fun ContributorCard( | |||
| } | |||
| } | |||
|
|
|||
| private val CardBackgroundColor = Color(0xFFEEFFE7) | |||
There was a problem hiding this comment.
@laco-dev https://github.com/droidknights/DroidKnights2023_App/pull/126/files 에서 추가된 값으로 보이는데요, 하드코딩 컬러를 사용하시는 별다른 이유가 없다면 Neon05로 대체하려고 합니다.
laco-dev
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Screenshot