Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#110 [designsystem] 테마에 맞는 이미지를 가져오기 위한 편의 함수 추가 #111

Merged
merged 2 commits into from
Jul 26, 2023
Merged

#110 [designsystem] 테마에 맞는 이미지를 가져오기 위한 편의 함수 추가 #111

merged 2 commits into from
Jul 26, 2023

Conversation

laco-dev
Copy link
Contributor

Issue

Overview (Required)

  • 라이트 모드/ 다크 모드에 맞는 이미지를 반환하도록 하는 컴포저블 함수

Usage

val painter = rememberPainterResource(R.drawable.img_light, R.drawable.img_dark)

@laco-dev laco-dev requested a review from wisemuji July 26, 2023 13:59
wisemuji
wisemuji approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 제안이 있지만 어프루브입니다

core/designsystem/src/main/java/com/droidknights/app2023/core/designsystem/res/Painter.kt Outdated Show resolved Hide resolved
@laco-dev @wisemuji
Update core/designsystem/src/main/java/com/droidknights/app2023/core/…
79a19fe 
…designsystem/res/Painter.kt

Co-authored-by: Suhyeon Kim <[email protected]>
@laco-dev laco-dev merged commit 5d518f7 into droidknights:main Jul 26, 2023
@laco-dev laco-dev deleted the feature/#110 branch July 26, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisemuji wisemuji wisemuji approved these changes

Assignees

@laco-dev laco-dev

Labels
2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[designsystem] 테마에 맞는 이미지를 가져오기 위한 편의 함수 추가
3 participants
@laco-dev @wisemuji @taehwandev