Remove temporary _cat/indices debug

This debug was never logged, so although elastic#45652
is not yet fixed there is no point keeping it.

The strange IndexNotFoundException comes entirely
from the authz layer.

Relates elastic#46739
Relates elastic#45652

server/src/main/java/org/elasticsearch/rest/action/cat/RestIndicesAction.java

@@ -42,7 +42,6 @@
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.common.time.DateFormatter;
 import org.elasticsearch.common.unit.TimeValue;
-import org.elasticsearch.index.IndexNotFoundException;
 import org.elasticsearch.index.IndexSettings;
 import org.elasticsearch.rest.RestController;
 import org.elasticsearch.rest.RestRequest;
@@ -126,11 +125,6 @@ public void onResponse(final GetSettingsResponse getSettingsResponse) {
 
                 @Override
                 public void onFailure(final Exception e) {
-                    // Temporary logging to help debug https://github.com/elastic/elasticsearch/issues/45652
-                    // TODO: remove this when we understand why _cat/indices sometimes returns a 404
-                    if (e instanceof IndexNotFoundException) {
-                        logger.debug("_cat/indices returning index_not_found_exception", e);
-                    }
                     listener.onFailure(e);
                 }
             });

x-pack/plugin/ml/qa/native-multi-node-tests/build.gradle

@@ -55,8 +55,6 @@ testClusters.integTest {
     setting 'xpack.security.audit.enabled', 'false'
     setting 'xpack.license.self_generated.type', 'trial'
     setting 'xpack.ml.min_disk_space_off_heap', '200mb'
-    // TODO: remove when the cause of https://github.com/elastic/elasticsearch/issues/45652 is understood
-    setting 'logger.org.elasticsearch.rest.action.cat', 'DEBUG'
 
     keystore 'bootstrap.password', 'x-pack-test-password'
     keystore 'xpack.security.transport.ssl.secure_key_passphrase', 'testnode'