Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed failing tests on Windows #216

Merged
merged 3 commits into from
May 26, 2020
Merged

Fixed failing tests on Windows #216

merged 3 commits into from
May 26, 2020

Conversation

omri374
Copy link
Contributor

@omri374 omri374 commented May 24, 2020 •
edited
Loading

Casting Path objects to strings due to an issue with WindowsPath:

TypeError: argument of type 'WindowsPath' is not iterable

Fixes #215

@omri374
Fixed failing tests on Windows
db30691 
Due to an issue with WindowsPath
pjbull
pjbull requested changes May 24, 2020
View reviewed changes
Copy link
Member

@pjbull pjbull left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Tiny little tweak: We've got a preference to keep Path objects as long as possible before strigifying. This way if in the future we want to do Path manipulation. Can you move the str to the next line like this: args = ['python', str(setup_), '--license']. That way in the future if we want to use setup_` like a path for some reason we can.

@omri374
Copy link
Contributor Author

omri374 commented May 25, 2020

@pjbull Done

@pjbull pjbull merged commit 5f54d39 into drivendataorg:master May 26, 2020
niedakh added a commit to spokencloud/avaya-data-science that referenced this pull request Oct 30, 2020
@niedakh
Merge pull request #1 from drivendata/master
eaa398b 
Fixed failing tests on Windows (drivendataorg#216)
izaakm added a commit to izaakm/cookiecutter that referenced this pull request Jan 31, 2023
@izaakm
Merge upstream: squashed the following commits:
da43851 
commit 52283f7
Author: Peter Bull <[email protected]>
Date:   Fri Mar 11 10:27:47 2022 -0800

    Revert "Flag -c v1 is slightly confusing in branch v2 (drivendataorg#264)"

    This reverts commit d82776e.

commit d82776e
Author: Shubhankar <[email protected]>
Date:   Fri Mar 11 12:25:13 2022 -0600

    Flag -c v1 is slightly confusing in branch v2 (drivendataorg#264)

commit 319222f
Author: Jon Daniels <[email protected]>
Date:   Tue Jun 22 18:23:22 2021 -0600

    Update index.md (drivendataorg#249)

    changing from "be" to "by"

commit c077603
Author: Peter Bull <[email protected]>
Date:   Fri Mar 19 22:33:34 2021 -0700

    V1 tag and deprecation (drivendataorg#240)

    * deprecation warning

    * Update message and CLI call

    * Add to readme as well

commit 3978e7d
Author: Arturo Moncada-Torres <[email protected]>
Date:   Sat Mar 6 19:11:46 2021 +0100

    Update documentation (drivendataorg#243)

    Add explicit definition of DAG (as requested in issue drivendataorg#69)

commit 9bac80a
Author: Bernardo Amaral <[email protected]>
Date:   Thu Jan 21 23:12:54 2021 +0000

    Added setup.py to README's project organization (drivendataorg#236)

    Co-authored-by: bnamaral <[email protected]>

commit 0113a4a
Author: Peter Bull <[email protected]>
Date:   Tue Dec 22 10:46:23 2020 -0800

    Update example

commit fcc59e3
Author: Peter Bull <[email protected]>
Date:   Thu Dec 10 09:12:53 2020 -0800

    3.5 +

commit 5f54d39
Author: Omri Mendels <[email protected]>
Date:   Tue May 26 20:16:03 2020 +0300

    Fixed failing tests on Windows (drivendataorg#216)

    * Fixed failing tests on Windows

    Due to an issue with WindowsPath

    * Update test_creation.py

    * Update test_creation.py

commit 78e001f
Author: Natrave Drova <[email protected]>
Date:   Thu Apr 23 08:14:31 2020 +0300

    Tox reference (drivendataorg#211)

    * Use a better link to the tox project

    * Use a better link to the tox project

    * Use a better link to the tox project

commit 26c62b4
Author: Fokko Driesprong <[email protected]>
Date:   Mon Apr 6 18:05:54 2020 +0200

    Typo (drivendataorg#208)

commit 1fbe58b
Author: Christopher Geis <[email protected]>
Date:   Mon Sep 23 17:49:26 2019 +0200

    Fixed: Typo in Makefile (drivendataorg#184)

    Fixed typo in Makefile, section "Set up python interpreter environment": intalled --> installed

commit ccbe207
Author: Wes Roach <[email protected]>
Date:   Wed Sep 4 12:29:26 2019 -0500

    Fix broken Airflow link (drivendataorg#182)

commit 7dcc59d
Author: Jonathan Raviotta <[email protected]>
Date:   Fri May 24 12:58:50 2019 -0400

    Added source and destination to Make data target (drivendataorg#169)

commit 997a9db
Author: Eric Jalbert <[email protected]>
Date:   Mon May 6 12:41:28 2019 -0400

    Change archived asciinema example (drivendataorg#163)

    * Change archived asciinema example

    * Update README.md

    Fix Asciinema powerline error

    * Update docs to show updated asciinema example
GatlenCulp pushed a commit to GatlenCulp/gatlens-opinionated-template that referenced this pull request Jan 29, 2025
@omri374
Fixed failing tests on Windows (drivendataorg#216)
6ac7c4a 
* Fixed failing tests on Windows

Due to an issue with WindowsPath

* Update test_creation.py

* Update test_creation.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbull pjbull pjbull requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo tests are failing on Windows
2 participants
@omri374 @pjbull