Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Support custom mapper. #12

Merged
merged 1 commit into from
Nov 20, 2024
Merged

feat!: Support custom mapper. #12

merged 1 commit into from
Nov 20, 2024

Conversation

driessamyn
Copy link
Owner

Enhance the query API to support specifying a custom mapper function.

Enhance the query API to support specifying a custom mapper function.
@driessamyn
Copy link
Owner Author

@CodiumAI-Agent /review

@CodiumAI-Agent
Copy link

CodiumAI-Agent commented Nov 19, 2024

PR Reviewer Guide 🔍

(Review updated until commit bfca24a)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Code Duplication
The newly added query methods in the Kapper interface and KapperImpl class seem to duplicate existing functionality with minor variations. Consider refactoring to minimize code duplication and improve maintainability.

TODO Comments
There are multiple TODO comments related to caching and refactoring that should be addressed or tracked in a project management tool to ensure they are not overlooked.

Exception Handling
The createInstance method throws a KapperMappingException if the number of columns does not match the expected number. This could be handled more gracefully or documented clearly in the method's comments to inform users of the API.

Copy link

Test Results

 6 files  ±0   6 suites  ±0   2s ⏱️ ±0s
23 tests ±0  21 ✅ ±0  2 💤 ±0  0 ❌ ±0 
35 runs  +2  33 ✅ +2  2 💤 ±0  0 ❌ ±0 

Results for commit bfca24a. ± Comparison against base commit 72dfb06.

Copy link

@CodiumAI-Agent
Copy link

Persistent review updated to latest commit bfca24a

@driessamyn driessamyn merged commit 52d4e17 into main Nov 20, 2024
2 checks passed
@driessamyn driessamyn deleted the support-custom-mapper branch November 20, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants