Convert :poko-tests to single module
#469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Runs 1 and 2 are considerably slower than I'd hoped for and expected. I think I'm just getting unlucky with slow GitHub machines, but it's hard to tell. |
|
Guess I'll just merge and see if we can live with it, and revisit if it's consistently terrible |
|
The main branch build immediately after merging this was as fast as our builds get, ~14 minutes, so I think we're in the clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:poko-tests-without-k2is now a Gradle property setting on the:poko-testsmodule, instead of a copy/paste of the whole module. It will still be pretty easy to delete this once it's no longer needed.