Use reflection-based PsiElement in error reporting
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…piler vs. IDE packaging issue
drewhamilton
commented
Dec 10, 2024
Comment on lines
+88
to
+91
| try { | ||
| Class.forName("org.jetbrains.kotlin.com.intellij.psi.PsiElement") | ||
| } catch (_: ClassNotFoundException) { | ||
| Class.forName("com.intellij.psi.PsiElement") |
There was a problem hiding this comment.
I swapped the order from the example, because I think the former is the one used by the compiler while the latter is used by the IDE, and I want the compiler to be faster. Not sure about this though.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to work around compiler vs. IDE packaging issue.
I think this will address #428, but I'm having trouble verifying locally. The IDE keeps popping up the same error stacktrace, even though the
catchis now in place. Maybe it's using some kind of caching mechanism, so I'm just going to try and merge this and see if it fixes the issue.