Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address trivial IDE warnings #444

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Address trivial IDE warnings #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poko-compiler-plugin/src/main/kotlin/dev/drewhamilton/poko/ir/functionGeneration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ internal val IrTypeParameter.erasedUpperBound: IrClass
// In the second case, there is only a single supertype.
return when (val firstSuper = superTypes.first().classifierOrNull?.owner) {
is IrClass -> firstSuper
is IrTypeParameter -> firstSuper.erasedUpperBound
is IrTypeParameter -> @Suppress("RecursivePropertyAccessor") firstSuper.erasedUpperBound
else -> error("unknown supertype kind $firstSuper")
}
}
Expand Down
4 changes: 1 addition & 3 deletions sample/compose/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ if (jvmToolchainLanguageVersion != null) {

android {
namespace = "dev.drewhamilton.poko.sample.compose"
compileSdk = 33
compileSdk = 34

defaultConfig {
minSdk = 21
}

// TODO: Wrap in `if (jvmToolchainLanguageVersion == null)` from AGP 8.1
compileOptions {
sourceCompatibility(resolvedJavaVersion)
targetCompatibility(resolvedJavaVersion)
Expand All @@ -38,7 +37,6 @@ android {
freeCompilerArgs = listOf("-progressive")
}

@Suppress("UnstableApiUsage")
buildFeatures {
compose = true

Expand Down
3 changes: 2 additions & 1 deletion sample/jvm/src/testFixtures/kotlin/dev/drewhamilton/poko/sample/jvm/SampleFixture.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package dev.drewhamilton.poko.sample.jvm

@Suppress("unused") // Used to validate compilation works as expected
val SampleFixture = Sample(
int = 1,
requiredString = "String",
optionalString = null
)
)
Loading