Skip to content

Commit

Permalink
Update Kotlin plugin application
Browse files Browse the repository at this point in the history
This allows gradle-maven-publish-plugin to access KotlinMultiplatformExtension in build-support while avoiding a plugin version conflict in the main project. The desired version of the Kotlin compiler is still used.
  • Loading branch information
drewhamilton committed Dec 16, 2024
1 parent 011378f commit 9b060c4
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion build-support/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ repositories {
}

dependencies {
implementation(libs.kotlin.gradleApi)
implementation(libs.kotlin.gradle)
implementation(libs.plugin.buildconfig)
implementation(libs.plugin.mavenPublish)
implementation(libs.plugin.dokka)
Expand Down
4 changes: 2 additions & 2 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
alias(libs.plugins.kotlin.jvm) apply false
alias(libs.plugins.kotlin.multiplatform) apply false
// Note: kotlin-jvm and kotlin-multiplatform plugins are added implicitly via build-support

alias(libs.plugins.kotlinx.binaryCompatibilityValidator) apply false
alias(libs.plugins.ksp) apply false
}
Expand Down
1 change: 1 addition & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ kotlinCompileTestingFork = { module = "dev.zacsweers.kctfork:core", version.ref
kotlin-embeddableCompiler = { module = "org.jetbrains.kotlin:kotlin-compiler-embeddable", version.ref = "kotlin" }
kotlin-stdlib = { module = "org.jetbrains.kotlin:kotlin-stdlib", version.ref = "kotlin" }
kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }
kotlin-gradle = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
kotlin-gradleApi = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin-api", version.ref = "kotlin" }

assertk = "com.willowtreeapps.assertk:assertk:0.28.1"
Expand Down
2 changes: 1 addition & 1 deletion poko-annotations/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import org.jetbrains.kotlin.gradle.ExperimentalWasmDsl

plugins {
alias(libs.plugins.kotlin.multiplatform)
id("org.jetbrains.kotlin.multiplatform")
}

pokoBuild {
Expand Down
2 changes: 1 addition & 1 deletion poko-compiler-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
alias(libs.plugins.kotlin.jvm)
id("org.jetbrains.kotlin.jvm")
alias(libs.plugins.ksp)
}

Expand Down
2 changes: 1 addition & 1 deletion poko-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
plugins {
`java-gradle-plugin`
alias(libs.plugins.kotlin.jvm)
id("org.jetbrains.kotlin.jvm")
}

pokoBuild {
Expand Down
2 changes: 1 addition & 1 deletion poko-tests-without-k2/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import org.jetbrains.kotlin.gradle.plugin.PLUGIN_CLASSPATH_CONFIGURATION_NAME
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
alias(libs.plugins.kotlin.multiplatform)
id("org.jetbrains.kotlin.multiplatform")
}

tasks.withType<KotlinCompile>().configureEach {
Expand Down
2 changes: 1 addition & 1 deletion poko-tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import org.jetbrains.kotlin.gradle.plugin.NATIVE_COMPILER_PLUGIN_CLASSPATH_CONFI
import org.jetbrains.kotlin.gradle.plugin.PLUGIN_CLASSPATH_CONFIGURATION_NAME

plugins {
alias(libs.plugins.kotlin.multiplatform)
id("org.jetbrains.kotlin.multiplatform")
}

val jvmToolchainVersion: Int? = System.getenv()["poko_tests_jvm_toolchain_version"]?.toInt()
Expand Down
2 changes: 1 addition & 1 deletion poko-tests/performance/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
alias(libs.plugins.kotlin.jvm)
id("org.jetbrains.kotlin.jvm")
}

dependencies {
Expand Down

0 comments on commit 9b060c4

Please sign in to comment.