Update KnowledgeEndpoint to allow editing statements through the GUI #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devos50
changed the title
devos50
force-pushed
the
rename_tags_endpoint
branch
3 times, most recently
from
4c79b78
to
6b2ed93
Compare
devos50
force-pushed
the
rename_tags_endpoint
branch
from
6b2ed93
to
d50e672
Compare
drew2a
requested changes
Oct 18, 2022
Comment on lines
101
to
102
| await do_request(rest_api, 'knowledge/3f3/suggestions', expected_code=400) | ||
| await do_request(rest_api, 'knowledge/3f3f/suggestions', expected_code=400) |
There was a problem hiding this comment.
Now it is a bit unclear whether these suggestions are tags. I suggest renaming it to tag_suggestions
drew2a
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
TagsEndpointtoKnowledgeEndpoint