Support for roles in grants #259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmeireles
force-pushed
the
roles-grants
branch
from
22658f6 to
9a5b7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for roles in grants
Description
Grants can now be set for both users and for roles.
A prefix was added to handle this, with
user:androle:being the valid prefixes. For example,user:dbt_test_user_1androle:dbt_test_role_1.If no prefix is provided, defaults to user for backwards compatibility.
Test Results
Tested manually, currently working on tests that will test both user and role grants. Extending the pipeline will be needed again as we will also need to create the roles in the dremio instance used for testing
Changelog
Related Issue
#177