-
Notifications
You must be signed in to change notification settings - Fork 26
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Unnamed reflections now take the model name/alias (#264)
### Summary When creating a model for a reflection, if the name config parameter was not set, the reflection would be named `Unnamed Reflection` inside Dremio. ### Description Instead, the default behavior should be for the reflection to be named after the model name/alias The default behavior has been changed, it will now set the name attending to the following priority list: 1. Model config `name` parameter 2. Model config `alias` parameter 3. Model name ### Test Results Two new tests have been added to the test suit for reflections, one with the `alias` parameter and another one with the model name ### Changelog - [X] Added a summary of what this PR accomplishes to CHANGELOG.md ### Related Issue #263
- Loading branch information
1 parent
5c61612
commit 990e846
Showing
3 changed files
with
56 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters