Image manipulation & constraint improvements #15
Conversation
melbic
changed the title
melbic
changed the title
melbic
changed the title
and edit them before activating
| func withTintByMultiply(with color: UIColor) -> UIImage { | ||
| defer { UIGraphicsEndImageContext() } | ||
|
|
||
| UIGraphicsBeginImageContextWithOptions(size, false, UIScreen.main.scale) |
There was a problem hiding this comment.
I would prefer having the defer immediately after BeginImageContext.
| let origin = CGPoint(x: (newWidth - size.width) / 2, y: (newHeight - size.height) / 2) | ||
| draw(at: origin) | ||
| let imageWithPadding = UIGraphicsGetImageFromCurrentImageContext() | ||
| UIGraphicsEndImageContext() |
There was a problem hiding this comment.
Use a defer here as well to avoid issues with early returns in the future.
|
|
||
| let newHeight = size.height * 2 | ||
| let newSize = CGSize(width: size.width, height: newHeight) | ||
| UIGraphicsBeginImageContextWithOptions(newSize, false, 0) |
There was a problem hiding this comment.
Move defer after beginContext.
|
|
||
| func transparentImageBackgroundTo(_ color: UIColor) -> UIImage { | ||
| defer { UIGraphicsEndImageContext() } | ||
| UIGraphicsBeginImageContextWithOptions(size, false, scale) |
There was a problem hiding this comment.
Move defer after beginContext.
| return newImage | ||
| } | ||
|
|
||
| func transparentImageBackgroundTo(_ color: UIColor) -> UIImage { |
There was a problem hiding this comment.
Do we need this? Couldn't you just set the UIImageView's backgroundColor?
| import UIKit | ||
|
|
||
| public extension UIImageView { | ||
| class func autoLayout(image: UIImage?) -> Self { |
There was a problem hiding this comment.
We have similar issues with other views as well. Maybe we should just extend UIView with
func autoLayout() {
translatesAutoresizingMaskIntoConstraints = false
return self
}That way you could initialize your image view like let imageView = UIImageView(image: ...).autoLayout().
|
Code Climate has analyzed commit c83eb88 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks for your feedback. I changed the stuff as discussed. |
Bitte #16 auch noch gleich anschauen und mit beiden eine neue Version pushen. Danke tausig.