feat: pretraining matches paper #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimox
force-pushed
the
feat/update-pretraining
branch
from
803d77d to
7a919b1
Compare
eduardocarvp
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR takes into account the discussion from #291 in order to get a closer implementation from the research paper.
The decoder now uses GLU blocks and a final mapping layer to reconstruct the output from the different steps.
Does this PR introduce a breaking change?
I added new parameters in order to be able to decide the size of the decoding blocks.
What needs to be documented once your changes are merged?
I changed the README but I'm not sure it's clear enough.
Closing issues
closes #291